This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(typing): Update SearchResults hits, expose optional hit typings #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e0c4a2:
|
Haroenv
reviewed
Jul 21, 2022
Haroenv
approved these changes
Jul 25, 2022
dhayab
approved these changes
Jul 26, 2022
|
Sure, I'll handle that. Thanks for this contribution! |
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…lgolia/algoliasearch-helper-js#914) Co-authored-by: Haroen Viaene <[email protected]>
dhayab
added a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* feat(typing): Update SearchResults hits, expose optional hit typings (algolia/algoliasearch-helper-js#914) algolia/algoliasearch-helper-js@9fdfe99
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SearchResultshit and expose theHighlightResultRankingInfoandSnippetResulttypings for use elsewhere.@types/react-instantsearch-coretypes to use the actualSearchResultsfromalgoliasearch-helperrather than redefining their own.SearchResults+HighlightResults, etc.