This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(disjunctiveFacetParams): reduce payload size #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reduces the amount of params sent for each disjunctive facet request. It also reduces `hitsPerPage` from `1` to `0`, allowing us to remove the `attributes*` parameters at the same time. This reduces: * the payload sent by a few bytes * and the response size by a few extra bytes as the previous implem sent back one `objectID` per additional request
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02d7a9e:
|
Jerska
commented
Jun 23, 2022
Jerska
changed the title
Haroenv
reviewed
Jun 23, 2022
Jerska
commented
Jun 23, 2022
|
this looks great! I've tried it out in a sandbox here and everything works as expected https://codesandbox.io/s/javascript-helper-app-forked-jyn60w?file=/src/app.js Could you update the tests too? |
|
Yes I'm on it, but I'm currently struggling with the |
Haroenv
approved these changes
Jun 23, 2022
|
We can replace |
sarahdayan
approved these changes
Jun 24, 2022
Haroenv
added a commit
that referenced
this pull request
Jun 27, 2022
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…rch-helper-js#912) * feat(dijunctiveFacetParams): reduce payload size This PR reduces the amount of params sent for each disjunctive facet request. It also reduces `hitsPerPage` from `1` to `0`, allowing us to remove the `attributes*` parameters at the same time. This reduces: * the payload sent by a few bytes * and the response size by a few extra bytes as the previous implem sent back one `objectID` per additional request * feat(disjunctiveFacetParams): add responseFields * Update src/requestBuilder.js * chore: remove trailing whitespaces * feat: remove `responseFields` * feat: update unit tests Co-authored-by: Haroen Viaene <[email protected]>
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* feat(disjunctiveFacetParams): reduce payload size (algolia/algoliasearch-helper-js#912) algolia/algoliasearch-helper-js@6b87fd5 * feat(types): support algoliasearch v5 (algolia/algoliasearch-helper-js#910) algolia/algoliasearch-helper-js@8ed1b19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the amount of params sent for each disjunctive facet request.
It also reduces
hitsPerPagefrom1to0, allowing us to remove theattributes*parameters at the same time.This reduces:
objectIDper additional request