fix(env): don't assume process is defined

[Haroenv]

Summary

Most environments (webpack, browserify) by default define process as a shim for it.

However, some environements don't supply it, so we should always guard against it not being defined

fixes #691

(should be tested in a real angular app first)

Result

guards around every use of process

[Haroenv]

shoot, this somehow makes browserify add an extra polyfill for process in the bundle 😡

[vvo]

This one is actually only needed in integration tests and could be turned into a hidden option (__resetAppDataTimer)

[vvo]

Can we make it so that the fix is inside Angular InstantSearch?
The one you proposed @Haroenv, can we ship it inside Angular InstantSearch?

(window as any).process = {
  env: { DEBUG: undefined },
};

I am trying to find "the good way" to fix this in the community, as using process.env is common I am not sure of the right way to rewrite it.

[Haroenv]

That could be an option, I’ll try that out

[iam4x]

I've tried to hotfix this into Angular InstantSearch directly with:

// HOTFIX: define process
if (typeof window !== "undefined") {
  (window as any).process = { env: {} };
} else if (typeof global !== "undefined") {
  (global as any).process = { env: {} };
}

As entry point before anything else, it does not work :/

[Haroenv]

Since the workaround works in user land and this is stalled on the fact that it adds an additional process polyfill in the bundles, I'll close this. We can revisit later, especially #692 (comment) can probably be done regardless

[keichinger]

@Haroenv can we maybe re-open this issue as it still breaks any Webpack web-only build for those people that don't want to ship extra polyfills or shims?

This fix would not only improve some broken builds right now but is also necessary if you want to support Webpack 5, as it'll get rid of node polyfills (see https://twitter.com/wSokra/status/1076126619146899462).

It seemed like a good idea for now but like a necessity for the future, IMO :)