Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid scan makes all following scans fail #16

Closed
salmar opened this issue Mar 22, 2019 · 2 comments
Closed

Invalid scan makes all following scans fail #16

salmar opened this issue Mar 22, 2019 · 2 comments

Comments

@salmar
Copy link

salmar commented Mar 22, 2019

When scanning an invalid QR (UUID), an item in the attendee list is shown with the message "Synchronisation in progress". All following valid scans are also displayed with the same message making it impossible to further scan QRs.

Steps to reproduce the behavior:

  1. Scan a valid UUID and check the attendee name shows up in the attendee list
  2. Scan an invalid UUID (it will appear with the message "Synchronisation in progress")
  3. Scan a valid UUID again, you will see the attendee name is not resolved and the UUID with the "Synchronisation in progress" message appears in the list instead. Repeat the process again, all scans will display the same message with no attendee data.

Expected behavior
An invalid scan should display an item in the list with an invalid message, the current message gives a false impression to the user who might think it's synchronising. It would be also helpful to be able to delete items from the list.

All valid scans after an invalid scan should work as expected, resolving the attendee data and displaying it in the list.

Screenshots
invalid-scan

Smartphone:

  • Device: OnePlus 6
  • OS: OxygenOS 9.0.4 (Android 9)
cbellone added a commit that referenced this issue Mar 30, 2019
+ UI improvements with synchronization status
@cbellone
Copy link
Member

cbellone commented Apr 3, 2019

The fix for this issue can now be tested on your devices by:

@cbellone
Copy link
Member

cbellone commented Apr 4, 2019

Tested

@cbellone cbellone closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants