This repository has been archived by the owner on Nov 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #8 by adding the ability to create containers with port forwarding. The changes are non-breaking:
DockerClient#createContainer(...)
updated to take a thirdportBindings
parameter that is an array ofPortBinding
s (defaulting to empty array - no port forwarding). (See doc comment for details) ofPortBinding
.DockerClient#start(...)
updated to return an array ofPortBinding
s -indicating the the actual port bindings. This is mainly for use cases where the client makes a request to forward to a random available host port (hostPort=0
), such that the client is able to get the actual bound port. If the requestedhostPort
is non-0, the return value should just be what the client provided.Changes were made to the Docker JSON model to support this.