-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for markdown files with italicization parser #10
Conversation
Oh, I forgot to revert the split condition back to |
OK. I reverted the split condition back to |
The paragraph issue might be a bit of a challenge, so a new issue could be created for that. However the punctuation issue is more within this scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug where the parser is not italicizing text when there is punctuation after it.
Ex: _Silver Blaze?_
index.js
line 121 and line 126 is the problem. Something seems to wrong with the regex where it's not catching punctuation.
Try these regex's:
/_(.*?)_/
/\*(.*?)\*/
It seems the issue is the regex not catching certain special characters, so I ended up listing them manually, like: |
Oh, reverted split, again. Really have to remember it before I push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex seems to work. The ideas I had to try and make it simpler didn't work, so this will do for now.
Overview
This pull request is meant to resolve #8.
The request adds support for markdown files, as well as parser for italicization from markdown input files.
Features
Code Changes
isMd
boolean variable as flag for processing.md
filesisMd
when a file has the.md
extension, to process them correctly.md
files for markdown file support*text*
or_text_
) with<i>
tag when writing output files, to support italicization in markdown files