Add Melissa Data to API Options #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreisner
requested changes
Aug 25, 2021
test/unit/lookups/melissa_test.rb
Outdated
| end | ||
|
|
||
| def test_raises_api_key_exception | ||
| Geocoder.configure Geocoder.configure(:always_raise => [Geocoder::InvalidApiKey]) |
There was a problem hiding this comment.
This looks like a possible typo (two Geocoder.configures).
lib/geocoder/results/melissa.rb
Outdated
Comment on lines
42
to
48
| def latitude | ||
| @data['Latitude'].to_f | ||
| end | ||
|
|
||
| def longitude | ||
| @data['Longitude'].to_f | ||
| end |
There was a problem hiding this comment.
The convention for Geocoder lookups is to implement a coordinates method that returns [lat, lon] rather than latitude and longitude methods (which are implemented in the base lookup).
README_API_GUIDE.md
Outdated
| @@ -165,6 +165,17 @@ The [Google Places Search API](https://developers.google.com/maps/documentation/ | |||
| * **Limitations**: ? | |||
| * **Notes**: You can use the open (non-licensed) API by setting: `Geocoder.configure(mapquest: {open: true})` (defaults to licensed version) | |||
|
|
|||
| ### Melissa Data (`:melissa`) | |||
There was a problem hiding this comment.
It looks like Melissa also offers IP address geocoding, so maybe we want to call this lookup :melissa_street, in case we want to add :melissa_ip later?
|
Perfect! Thanks very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.