-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of common
crate
#13
Comments
alexpovel
added a commit
that referenced
this issue
May 29, 2023
… own implementation Another nice win. See also #13
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's always tempting to have it, but it's also a smell. A first step was taken in 5664118 , using
itertools
'powerset
.Remaining items are:
instrament
: can be moved back intocore
, not used anyway else currently anywaystrings.titlecase
: looked around, as it seems very easy for there to be a crate for it, but no dice (funny that this is so "hard"):https://crates.io/crates/capitalize: doesascii_lowercase
, which we cannot usehttps://crates.io/crates/roe: looks good and professional, but it's work in progress, and as of0.0.4
only has lower- and uppercasing, no titlecasinghttps://crates.io/crates/titlecase: specifically ignores words, which we cannot dobinary_search_uneven
: currently only lives externally because of benchmarks, as Criterion benchmarks can only use the public APIis_compound_word
: small function but unlikely to find a suitable crate for that. Lives externally becausebuild.rs
prepares the word list using that same algorithm (so that the processed word list doesn't contain compound words, as that would be wasted space)The text was updated successfully, but these errors were encountered: