Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of common crate #13

Closed
4 tasks done
alexpovel opened this issue May 29, 2023 · 2 comments
Closed
4 tasks done

Get rid of common crate #13

alexpovel opened this issue May 29, 2023 · 2 comments

Comments

@alexpovel
Copy link
Owner

alexpovel commented May 29, 2023

It's always tempting to have it, but it's also a smell. A first step was taken in 5664118 , using itertools' powerset.

Remaining items are:

  • instrament: can be moved back into core, not used anyway else currently anyway
  • strings.titlecase: looked around, as it seems very easy for there to be a crate for it, but no dice (funny that this is so "hard"):
  • binary_search_uneven: currently only lives externally because of benchmarks, as Criterion benchmarks can only use the public API
  • is_compound_word: small function but unlikely to find a suitable crate for that. Lives externally because build.rs prepares the word list using that same algorithm (so that the processed word list doesn't contain compound words, as that would be wasted space)
alexpovel added a commit that referenced this issue May 29, 2023
… own implementation

Another nice win. See also #13
@alexpovel
Copy link
Owner Author

binary_search_uneven could maybe be useful enough to be its own crate, but is_compound_word isn't. However, it looks like we cannot have these external/local dependencies on common when publishing. These items would need to be their own crate:

@alexpovel
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant