Fix ForwardRef on 3.12
#25
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Do they not happen locally? |
| type_params: ( | ||
| tuple[typing.TypeVar | typing.ParamSpec | typing.TypeVarTuple, ...] | ||
| | frozenset[str] | ||
| | None | ||
| ) = None, | ||
| recursive_guard: frozenset[str] | None = None, |
There was a problem hiding this comment.
| type_params: ( | |
| tuple[typing.TypeVar | typing.ParamSpec | typing.TypeVarTuple, ...] | |
| | frozenset[str] | |
| | None | |
| ) = None, | |
| recursive_guard: frozenset[str] | None = None, | |
| *args: Any, **kwargs: Any |
and then pass those through, much simpler and safer. I don't think this version of ForwardRef needs to be particularly user-friendly or well-hinted, and accurate hints depend on the Python version anyway. @bswck wdyt?
There was a problem hiding this comment.
@PerchunPak if you're happy with this suggestion then you can go ahead with it.
There was a problem hiding this comment.
and then pass those through, much simpler and safer. I don't think this version of
ForwardRefneeds to be particularly user-friendly or well-hinted, and accurate hints depend on the Python version anyway. @bswck wdyt?
Agree
There was a problem hiding this comment.
We can @functools.wraps(ForwardRef._evaluate) in case we want to be pedantic.
That... *should*... work.
Python 3.12 added a new argument which broke the library. It also made one of the arguments keyword-only which I also fixed.
|
Thanks @PerchunPak! |
Python 3.12 added a new argument which broke the library. It also made one of the arguments keyword-only which I also fixed.
Fixes #24