Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Fastboot compatibility #2

Closed
alexlafroscia opened this issue Jan 10, 2018 · 1 comment · Fixed by #16
Closed

Investigate Fastboot compatibility #2

alexlafroscia opened this issue Jan 10, 2018 · 1 comment · Fixed by #16
Labels
enhancement Improvement to an existing feature or behavior

Comments

@alexlafroscia
Copy link
Owner

alexlafroscia commented Jan 10, 2018

  • Gatsby can create styles ahead of time, to avoid possible FOUC
  • Should see if Fastboot can inject the initial styles as well

Links

@alexlafroscia
Copy link
Owner Author

My thoughts here are that it would be something like:

  • The initializer that injects emotion support into components can check for Fastboot and optionally interface with emotion to determine what is being used by this component
  • That information is stored somewhere where the Fastboot node process can access it
    • Can the Node process communicate with the fastboot service somehow?
  • Before sending the dynamic index.html, inject the critical styles
  • Call the hydrate method in an initializer before the app boots on the client, preferably only if we know that some styles were inlined.

This is going to be challenging because all of the APIs in the documentation seem to be tailored to React. I need to see if there are lower-level APIs available

@alexlafroscia alexlafroscia added the enhancement Improvement to an existing feature or behavior label Jan 24, 2018
alexlafroscia added a commit that referenced this issue Jan 28, 2018
alexlafroscia added a commit that referenced this issue Jan 28, 2018
alexlafroscia added a commit that referenced this issue Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature or behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant