Simplifying the newDataClient generator

alexkappa · Feb 3, 2022 · 4905251 · 4905251
1 parent 070c51e
commit 4905251
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/auth0/data_source_auth0_client.go b/auth0/data_source_auth0_client.go
@@ -10,7 +10,9 @@ import (
 )
 
 func newDataClient() *schema.Resource {
-	clientSchema := newComputedClientSchema()
+	clientSchema := datasourceSchemaFromResourceSchema(newClient().Schema)
+	delete(clientSchema, "client_secret_rotation_trigger")
+
 	addOptionalFieldsToSchema(clientSchema, "name", "client_id")
 
 	return &schema.Resource{
@@ -19,12 +21,6 @@ func newDataClient() *schema.Resource {
 	}
 }
 
-func newComputedClientSchema() map[string]*schema.Schema {
-	clientSchema := datasourceSchemaFromResourceSchema(newClient().Schema)
-	delete(clientSchema, "client_secret_rotation_trigger")
-	return clientSchema
-}
-
 func readDataClient(d *schema.ResourceData, m interface{}) error {
 	clientId := auth0.StringValue(String(d, "client_id"))
 	if clientId != "" {