Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitter data to InfluxDB feed #136

Merged

Conversation

adamus1red
Copy link
Contributor

Also add the upload/download bits to fix #82, this adds an explicit download_bits and upload_bits to the results.

@alexjustesen
Copy link
Owner

Since we're not changing the DDL we don't want to add the fields to the Create method when executing a speedtest. We can however update the influx method to pull that data out of the data column which houses everything produced by the cli.

You'll want to make a couple changes...

  1. Remove all changes from App/Jobs/ExecSpeedtest.php
  2. Add 'data' => 'array' under 'scheduled' => 'boolean' in App/Models/Result so we can access the casted values
  3. Where you're referencing values from the data column in App/Models/Result you can now do that like so $this->data['ping']['jitter']

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Nov 10, 2022
Copy link
Owner

@alexjustesen alexjustesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in conversations on accessing information stored in the data column.

@alexjustesen
Copy link
Owner

Also just a heads up, you'll want to update your branch as I've added branch protections to ensure basic testing and code quality.

@alexjustesen alexjustesen merged commit 2bb13fa into alexjustesen:main Nov 10, 2022
@adamus1red adamus1red deleted the adamus1red/influx-more-data branch November 10, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Influx integration sends bytes sent rather than bandwidth measurement
2 participants