When setting keys in ECB mode, don't check IV length. #3
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to encrypt a string using a generated key and no IV because I'm using ECB. Here's my code:
When I go to set the key it fails giving this error:
Unhandled Exception: NoSuchMethodError: The getter 'length' was called on null.
With this partial stack trace:
Following this trace to
aes_crypt/src/aes.dart:199
I find this code:aes_crypt/lib/src/aes.dart
Line 199 in 68cb8f7
It checks the length of the IV even in ECB mode when ECB mode doesn't require an IV (if my understanding is correct).
I've made this check only occur when the mode is not ECB.