-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to click on a tag in the list of suggested tags to add it #2
Comments
I am very surprised that clicking on an item in the suggestion list doesn't select it. This seems like the most basic of desired behaviour. |
I agree, seems that I have overlooked this one. |
Any idea when you'll implement mouse click selection? |
jquery-textext is really an amazing project you got here, I mean I would rate it with the tagging ability of Stackoverflow and Facebook on the feature side of it, the only thing missing for me is the click ability, thanks for sharing your work with the world |
@jasondavis thnx! Not sure when exactly I'd be able to get to it. It would be awesome if you guys could take a look at it :) |
I would love to contribute but I am more of a backend coder, I am not currently skilled enough with Javascript. I did take a look at the code though just to get an idea, and in Autocomplete plugin I found this
I would imagine that is for doing what this question was about but since it does not do it, maybe this is for a different click event? |
An update, I have found how out more information. Here is an image that is more to the point of the problem... You have to click in the area highlighted with red for it to work as expected. So if you click anywhere outside of that red box it will not work, including on the actual text/name of the tag The ideal solution would allow you to click anywhere in the GREEN highlighted section to add that tag to the input box. If you watch this 2 minute video you can see, I am on Windows 7 with Chrome http://screencastle.com/watch/00ca12cc4d3e10de867b8404007f85a4 |
…usedown event in autocomplete used by the blur event to determine if it was triggered by a scroll click or an item selection, in which case we set focus back to the input instead of closing the autocomplete. Added a click listener to the document body that triggers the autocomplete to close when the click is not within the textext wrap element.
…usedown event in autocomplete used by the blur event to determine if it was triggered by a scroll click or an item selection, in which case we set focus back to the input instead of closing the autocomplete. Added a click listener to the document body that triggers the autocomplete to close when the click is not within the textext wrap element.
Any chance of merging one of these fixes into the main project |
Will merge it this weekend. Sorry about delay on this. |
Thank you! |
Merged. |
…batchev#28 - Suggestions aren't clickable when autocomplete is manually shown Problem is that the click event does not fire for some reason, however the mouseup event does. Likely browser lacking support, or the click event is cancelled by a bubbling event. However, this fixes the issue.
It would be nice to be able to Click on a tag once it is in the suggestion list
The text was updated successfully, but these errors were encountered: