Support Scoped Packages (i.e. @google)

[grant]

Packages that are scoped (Use @) break the image URL:
http://npm.packagequality.com/#?package=@google%2Fclasp

[alexfernandez]

Hi, sorry for the delay! It sounds good, care to venture a patch?

[grant]

I think we just need to URL escape the "Share this package" samples:

The solution is probably just encodeURIComponent this line:

package-quality/bin/app.js

Line 57 in 9ec476b

var packageName = request.params['package'].replace(/.png$/, '');

Example

encodeURIComponent('@google/clasp')
"%40google%2Fclasp"

http://npm.packagequality.com/shield/%40google%2Fclasp.svg

Workaround

You can escape yourself (rather than copying the sample) to get the correct URL.

[alexfernandez]

That is cool! If you propose a PR I will just accept it.

[grant]

It looks like this repo ignores local-config.js.

I also get the error:

/Users/granttimmerman/Documents/github/grant/package-quality/test.js:21
	log.debug('Running tests');
	    ^
TypeError: log.debug is not a function

[alexfernandez]

Again, I would appreciate it if you can submit a PR 😄

[grant]

Well, I'd submit a PR for the feature if the project build wasn't broken.

I can't say I'm going to (1) fix the project build, then (2) add a PR, since there's a fine workaround.

[alexfernandez]

Fair enough, I will try to repair the build and get back to you, OK?

[sasadjolic]

Any updates on adding support for scoped packages?

[sasadjolic]

I should mention that the workaround as described above in the history of this issue does not work anymore

[grant]

I added a PR that I believe fixes the URL rendered on the web page. Although I don't know if it fixes the related/new searching issue.

[alexfernandez]

Merged and restarted! But now https://packagequality.com/shield/%40google%2Fclasp.svg is yielding an error 🤔