Use cross to build linux artifact #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using cross, the build of the artifact will have a more stable ABI because the docker image has a [well defined version of libraries][1] that are defined, meaning that updates to "ubuntu-latest" won't impact the compatible version of the built binaries. This change defines the "toolchain" for rust, meaning that new versions of rust won't automatically be picked up (unless changed to stable). This also removes the `action-rs` uses, because they are deprecated and the github actions install rustup by default [1]: https://github.com/cross-rs/cross?tab=readme-ov-file#supported-targets
perryqh
approved these changes
Apr 25, 2024
perryqh
approved these changes
Apr 25, 2024
alexevanczuk
approved these changes
Apr 25, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using cross, the build of the artifact will have a more stable ABI because the docker image has a well defined version of libraries that are defined, meaning that updates to "ubuntu-latest" won't impact the compatible version of the built binaries.
This change defines the "toolchain" for rust, meaning that new versions of rust won't automatically be picked up (unless changed to stable).
This also removes the
action-rsuses, because they are deprecated and the github actions install rustup by default