-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate architecture in architecture.rs #129
Validate architecture in architecture.rs #129
Conversation
@@ -102,6 +109,26 @@ impl PackSet { | |||
) | |||
}) | |||
} | |||
|
|||
// Returns all of the package dependencies in the pack set. | |||
pub fn all_pack_dependencies<'a>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -342,24 +314,4 @@ packs/foo, packs/bar", | |||
|
|||
checker.validate(&configuration); | |||
} | |||
|
|||
#[test] | |||
fn test_validate_with_architecture_violations() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to move this test to architecture.rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One comment on a test that I think we lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks for the cleanup!
No description provided.