Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate architecture in architecture.rs #129

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

perryqh
Copy link
Contributor

@perryqh perryqh commented Nov 28, 2023

No description provided.

@@ -102,6 +109,26 @@ impl PackSet {
)
})
}

// Returns all of the package dependencies in the pack set.
pub fn all_pack_dependencies<'a>(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -342,24 +314,4 @@ packs/foo, packs/bar",

checker.validate(&configuration);
}

#[test]
fn test_validate_with_architecture_violations() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to move this test to architecture.rs?

Copy link
Owner

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One comment on a test that I think we lost

@perryqh perryqh requested a review from alexevanczuk November 28, 2023 22:37
Copy link
Owner

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for the cleanup!

@alexevanczuk alexevanczuk merged commit e023414 into alexevanczuk:main Nov 29, 2023
@perryqh perryqh deleted the architecture-validation branch December 19, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants