Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore recorded violations #103

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Add option to ignore recorded violations #103

merged 3 commits into from
Jul 31, 2023

Conversation

oleg-vinted
Copy link
Contributor

This adds a command-line option --ignore-recorded-violations to check and check-contents commands that skips filtering out recorded violations. This is especially useful in editor integrations to see all the violations, even those recorded in package_todo.yml.

@oleg-vinted oleg-vinted mentioned this pull request Jul 31, 2023
Merged
alexevanczuk
alexevanczuk reviewed Jul 31, 2023
View reviewed changes
Copy link
Owner

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Want to add a test for it, maybe in check_test.rs?

@alexevanczuk
Copy link
Owner

Nice thanks!

@alexevanczuk alexevanczuk merged commit 8e54df0 into alexevanczuk:main Jul 31, 2023
@oleg-vinted oleg-vinted deleted the feature/ignore_recorded_violations_switch branch July 31, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexevanczuk alexevanczuk alexevanczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleg-vinted @alexevanczuk