Ignore invalid symlinks (#179)

* swallowing invalid symlink errors to be consistent with packwerk

* bumping version to 0.1.92

Cargo.toml

@@ -2,7 +2,7 @@
 
 [package]
 name = "pks"
-version = "0.1.91"
+version = "0.1.92"
 edition = "2021"
 description = "Welcome! Please see https://github.com/alexevanczuk/packs for more information!"
 license = "MIT"

src/packs/walk_directory.rs

@@ -135,7 +135,12 @@ pub(crate) fn walk_directory(
         //     .unwrap();
         // writeln!(file, "{:?}", entry).unwrap();
 
-        let unwrapped_entry = entry?;
+        let unwrapped_entry = entry;
+        if let Err(_e) = unwrapped_entry {
+            // Encountered an invalid symlink. Being consistent with packwerk, which swallows this error and continues
+            continue;
+        }
+        let unwrapped_entry = unwrapped_entry.unwrap();
 
         // Note that we could also get the dir from absolute_path.is_dir()
         // However, this data appears to be cached on the FileType struct, so we'll use that instead,
@@ -228,4 +233,31 @@ mod tests {
 
         Ok(())
     }
+
+    #[test]
+    fn test_walk_directory_with_invalid_symlink() -> anyhow::Result<()> {
+        let absolute_path = PathBuf::from("tests/fixtures/app_with_symlink")
+            .canonicalize()
+            .expect("Could not canonicalize path");
+
+        let raw_config = RawConfiguration {
+            include: vec!["**/*".to_string()],
+            ..RawConfiguration::default()
+        };
+
+        // deleting baz
+        // link-baz -> baz
+        let baz_path = absolute_path.join("packs/foo/app/services/baz");
+        let _ignore = std::fs::remove_dir_all(&baz_path);
+
+        let walk_directory_result =
+            walk_directory(absolute_path.clone(), &raw_config);
+
+        // Restoring baz
+        std::fs::create_dir_all(&baz_path)?;
+
+        assert!(walk_directory_result.is_ok());
+
+        Ok(())
+    }
 }

tests/fixtures/app_with_symlink/app/company_data/widget.rb

@@ -0,0 +1,3 @@
+module Company
+  class Widget end
+end

tests/fixtures/app_with_symlink/app/services/some_root_class.rb

@@ -0,0 +1 @@
+class SomeRootClass; end

tests/fixtures/app_with_symlink/packs/foo/app/services/foo.rb

@@ -0,0 +1,9 @@
+module Foo
+  def calls_bar_without_a_stated_dependency
+    ::Bar
+  end
+
+  def calls_baz_with_a_stated_dependency
+    Baz
+  end
+end

tests/fixtures/app_with_symlink/packs/foo/app/services/foo/bar.rb

@@ -0,0 +1,5 @@
+# This defines ::Foo::Bar, which is different than ::Bar
+module Foo
+  module Bar
+  end
+end

tests/fixtures/app_with_symlink/packs/foo/app/services/link-baz

@@ -0,0 +1 @@
+baz

tests/fixtures/app_with_symlink/packs/foo/app/views/foo.erb

@@ -0,0 +1 @@
+

tests/fixtures/app_with_symlink/packs/foo/package.yml

@@ -0,0 +1,2 @@
+enforce_dependencies: true
+enforce_privacy: true

tests/fixtures/app_with_symlink/packwerk.yml

@@ -0,0 +1,3 @@
+# Whether or not you want the cache enabled (disabled by default)
+cache: false
+

tests/fixtures/app_with_symlink/script/my_script.rb

@@ -0,0 +1 @@
+# some ruby script