Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IntelArch restriction from some app installs #946

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Jun 25, 2023

Remove IntelArch restriction from the following app installs:

  • argocd
  • consul-connect
  • falco
  • gitea
  • jenkins
  • kube-state-metrics
  • kyverno
  • metallb-arp
  • rabbitmq
  • redis
  • tekton
  • waypoint

Description

  • Remove IntelArch check from apps that now support linux/arm64
  • Update metallb manifests to v0.13.10 (latest) for compatibility with current k8s

NOTE: falco ARM support requires linux/arm64/v8

Motivation and Context

Fixes #944

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Installed everything (one at a time) in rancher-desktop (k3s) on Apple M1

Everything installed and was healthy, except falco, whose falco-driver-loader container (1 of 4) failed to download a driver. I don't think this is an issue with falco's arm64 support per se, as falco provides linux/arm64/v8 images. The falco-driver-loader container issue may be related to falcosecurity/falco#2431

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@joebowbeer joebowbeer mentioned this pull request Jun 25, 2023
11 tasks
@alexellis alexellis merged commit 3a36fb5 into alexellis:master Jun 28, 2023
@alexellis
Copy link
Owner

Thanks for doing this @joebowbeer - I always appreciate seeing the testing like you've provided here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate removing IntelArch restriction from app installs
2 participants