fix(executor): Correct usage of time.Duration. Fixes argoproj#5046

Signed-off-by: Alex Collins <[email protected]>
alexec · Feb 9, 2021 · e028ad5 · e028ad5
1 parent da0e5cb
commit e028ad5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/workflow/executor/executor.go b/workflow/executor/executor.go
@@ -682,10 +682,10 @@ func (we *WorkflowExecutor) GetSecrets(ctx context.Context, namespace, name, key
 // GetTerminationGracePeriodDuration returns the terminationGracePeriodSeconds of podSpec in Time.Duration format
 func (we *WorkflowExecutor) GetTerminationGracePeriodDuration(ctx context.Context) (time.Duration, error) {
 	pod, err := we.getPod(ctx)
-	if err != nil {
+	if err != nil || pod.Spec.TerminationGracePeriodSeconds == nil {
 		return time.Duration(0), err
 	}
-	terminationGracePeriodDuration := time.Second * time.Duration(*pod.Spec.TerminationGracePeriodSeconds))
+	terminationGracePeriodDuration := time.Second * time.Duration(*pod.Spec.TerminationGracePeriodSeconds)
 	return terminationGracePeriodDuration, nil
 }