Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from argoproj:master #126

Merged
merged 1 commit into from
Jan 27, 2020
Merged

[pull] master from argoproj:master #126

merged 1 commit into from
Jan 27, 2020

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 27, 2020 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]. Want to support this open source service? Please star it : )

@jannfis
fix: Better handling of K8s secrets for repository credentials & temp…
9790a5d 
…lates (#3016 #3028) (#3029)

* Fix for calculation of credential secrets' names and secret deletion

* Fix comments to reflect reality

* Update unit tests

* Don't encode parts of the repo URL into secret names anymore

* Lint fixes

* Satisfy linter: Remove unused variable

* Retrigger stuck CI
@pull pull bot added the ⤵️ pull label Jan 27, 2020
@pull pull bot merged commit 9790a5d into alexec:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jannfis