fix(builtin): Update to latest ncc

This contains a fix for how browserify is built, so that builtin modules don't get arbitrary webpack-assigned module IDs Fixes bazel-contrib#771
alexeagle · Jul 2, 2019 · eeaf0ca · eeaf0ca
1 parent 8cdd60d
commit eeaf0ca
Show file tree

Hide file tree

Showing 33 changed files with 30,607 additions and 48,484 deletions.
diff --git a/package.json b/package.json
@@ -15,7 +15,7 @@
         "@bazel/ibazel": "0.10.1",
         "@commitlint/cli": "^8.0.0",
         "@commitlint/config-conventional": "^8.0.0",
-        "@zeit/ncc": "0.18.1",
+        "@zeit/ncc": "0.20.2",
         "bazel_workspaces": "file:./tools/npm_packages/bazel_workspaces",
         "browserify": "16.2.3",
         "clang-format": "1.2.2",

diff --git a/scripts/vendor_browserify.sh b/scripts/vendor_browserify.sh
@@ -11,6 +11,6 @@ echo "Compiling browserify with ncc"
 echo "Copy LICENSE"
 cp -f ./node_modules/browserify/LICENSE ./third_party/github.com/browserify/browserify
 
-echo "Minifying browserify with tserver"
+echo "Minifying browserify with terser"
 ./node_modules/.bin/terser --compress --mangle --comments '/(^!|@license|@preserve)/' -- third_party/github.com/browserify/browserify/index.js > third_party/github.com/browserify/browserify/index.min.js