Message enhancements #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2022 10:53
useful when/if we want to try to generate a MIC using algo specified by partner
> DEPRECATED: Use assert_nil if expecting nil from test/message_test.rb:215. > This will fail in Minitest 6.
…ease.
1. allow caller to specify how message content is encoded. alternative: try
both and use begin/rescue to detect if the first attempt fails.
2. allow caller to specify which algorithm to use for MIC generation.
this would be extracted from HTTP Disposition-Notification-Options header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvements to
As2::Message. Unsure if these will be released or not. Saving here for visibility.