Handling unwrap errors in lib.rs #99
Conversation
|
"Failed to find path" does not seem to be a very helpful message when the actual problem is a non-UTF8 path. |
|
Turns out there was another one I was hitting, so I've updated that as well. |
|
Are these unwraps getting hit frequently in practice? I think it's fine to get a better error message for when they are hit but if it's frequent then I'd want to fix the underlying issue ideally. |
yaleman
changed the title
|
I had the issue, and looking in the issues for this project, it looks like the following tickets are related: #30, #47, #94. My issue was that I was missing |
src/lib.rs
Outdated
| let status = match command.status() { | ||
| Ok(value) => value, | ||
| Err(error) => { | ||
| panic!("Error running command {:?} => {:?}", command, error); |
There was a problem hiding this comment.
I don't think the command needs to be printed again because it was already printed a few lines above this?
| None => { | ||
| panic!("Failed to convert path to string: {:?}", &path); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Could this and the above to_str use a helper function instead of duplicating?
This blind unwrap seems to be a very common error in builds, when it panics it gives the end user no clear way of identifying what's wrong, this PR adds some handling to show the file path that can't be found.