Refactor, improvement and PHP 8.1 only

[guidobonuzzi]

This PR includes:

• The constructor is now private
• Static constructor between, after, before, forEmptySequence, fromString
• Creating a Rank at the beginning or at the end is now more efficient
• rankValidator with new Exceptions
• Tests improvement
• Psalm
• Coding standard
• Infection wind Mutation Score Indicator (MSI) of 99%

A new major release is needed, compatibility is broken because the new constructor is private.

[Ocramius]

@alexcrawford to be clear, this PR is a proposal for a new major release of this library.

Up to you if you are interested in it: it was done in good faith, to improve the API, stability and behaviour of the library.

I asked @guidobonuzzi to contribute it back to your original project, rather than having us maintain a private fork: hope it is well perceived 👍

[Ocramius]

LGTM: mostly needs small CI and artifact -related changes

[alexcrawford]

Looks interesting - I will do some integration testing tomorrow.

Is it good practice to commit composer.lock in a project like this?

[guidobonuzzi]

Looks interesting - I will do some integration testing tomorrow.

Is it good practice to commit composer.lock in a project like this?

I added composer.lock to .gitignore to prevent commit, but I don't have a sure answer, probably you are right...

@Ocramius, what is the right answer?

[alexcrawford]

Ignore my last, I see it's still listed in .gitignore. I should have had my morning coffee before looking at it!

[Ocramius]

FWIW, I endorse committing it, but only in combination with lowest+latest CI pipelines.

The pipeline I proposed @guidobonuzzi to include yesterday has that feature 👍

[Ocramius]

CI won't work here until merged (due to GitHub security model - that's normal).

Meanwhile, here are the CI run results on the fork: https://github.com/KanbanBOX/lexorank-php/actions/runs/3198936467

[guidobonuzzi]

CI won't work here until merged (due to GitHub security model - that's normal).

Meanwhile, here are the CI run results on the fork: https://github.com/KanbanBOX/lexorank-php/actions/runs/3198936467

It's impressive how simple it is to implement! Thank you @Ocramius

[Ocramius]

Worked on it for a couple years @_@

[Ocramius]

Let's please use ^8.0 - we don't know if PHP 9.0 will be compatible :D

I also endorse ~8.0 || ~8.1, as explained in laminas/laminas-diactoros#117 (comment)

[Ocramius]

@guidobonuzzi important to fix this previous to merge BTW

[Ocramius]

Handled in 6a3df83

[Ocramius]

That was quick :O

[alexcrawford]

Merged and released as 2.0.0

[Ocramius]

Thanks @guidobonuzzi @alexcrawford! 🥳

[guidobonuzzi]

Thanks!

[boesing]

FYI as I stumbled upon this: ~8.0 === ^8.0

[Ocramius]

Argh, indeed @_@