Add comments to dom_patch.js

alexcastano · Nov 6, 2023 · ce7c2f0 · ce7c2f0
1 parent 0f67cf1
commit ce7c2f0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/assets/js/phoenix_live_view/dom_patch.js b/assets/js/phoenix_live_view/dom_patch.js
@@ -124,6 +124,8 @@ export default class DOMPatch {
         childrenOnly: targetContainer.getAttribute(PHX_COMPONENT) === null,
         getNodeKey: (node) => {
           if(DOM.isPhxDestroyed(node)){ return null }
+          // If we have a join patch, then by definition there was no PHX_MAGIC_ID.
+          // This is important to reduce the amount of elements morphdom discards.
           if(isJoinPatch){ return node.id }
           return node.id || (node.getAttribute && node.getAttribute(PHX_MAGIC_ID))
         },