Add listener TLS certificates for VirtualNodes and VirtualGateways #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows customers to include an ACM certificiate or specify a file certificate for their listeners to use to terminate TLS.
sshver
reviewed
Nov 17, 2020
alexbrjo
commented
Nov 17, 2020
dfezzie
suggested changes
Nov 18, 2020
dfezzie
reviewed
Nov 18, 2020
sshver
reviewed
Dec 3, 2020
sshver
reviewed
Dec 3, 2020
sshver
reviewed
Dec 3, 2020
sshver
reviewed
Dec 3, 2020
sshver
reviewed
Dec 3, 2020
|
got pre-lim feedback so PR'ing main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit and integ tests. Adds a dependency on ACM. Some notes because I don't know typescript or cdk:
bind()functions need to consume scope?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license