Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore unrecognized arguments #266

Merged
merged 4 commits into from
Mar 30, 2021
Merged

Ignore unrecognized arguments #266

merged 4 commits into from
Mar 30, 2021

Conversation

gaborbarna
Copy link
Contributor

No description provided.

@gaborbarna
Copy link
Contributor Author

@alexarchambault Hey, what do you think about this change?

alexarchambault
alexarchambault reviewed Mar 30, 2021
View reviewed changes
Copy link
Owner

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only left a comment, about under-tested aspects of case-app.

cats/shared/src/main/scala/caseapp/cats/IOCaseApp.scala Show resolved Hide resolved
alexarchambault
alexarchambault approved these changes Mar 30, 2021
View reviewed changes
Copy link
Owner

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/shared/src/test/scala/caseapp/demo/Demo.scala
@@ -123,18 +123,27 @@ object ManualCommandNotAdtStuff {
}
}

case object Command5IgnoreUnrecognized extends CaseApp[ManualCommandNotAdtOptions.Command5Opts] {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten about that file ^^ That's where this should have been tested 👍

@alexarchambault alexarchambault merged commit 64134f0 into alexarchambault:master Mar 30, 2021
@gaborbarna
Copy link
Contributor Author

@alexarchambault Thanks, can you please release the latest version to maven?

@alexarchambault
Copy link
Owner

I had cut a release, but it seems something went wrong during the release job. I'll have a look later this week I think.

@gaborbarna
Copy link
Contributor Author

I had cut a release, but it seems something went wrong during the release job. I'll have a look later this week I think.

Hey, any news on that front?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaborbarna @alexarchambault