Support custom name formatter when using withHelp (#188)

alexarchambault · Mar 16, 2020 · c276486 · c276486
1 parent 85e378a
commit c276486
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/core/shared/src/main/scala/caseapp/core/parser/Parser.scala b/core/shared/src/main/scala/caseapp/core/parser/Parser.scala
@@ -189,7 +189,7 @@ abstract class Parser[T] {
     */
   final def withHelp: Parser[WithHelp[T]] = {
     implicit val parser: Parser.Aux[T, D] = this
-    val p = Parser[WithHelp[T]]
+    val p = ParserWithNameFormatter(Parser[WithHelp[T]], defaultNameFormatter)
     if (defaultStopAtFirstUnrecognized)
       p.stopAtFirstUnrecognized
     else

diff --git a/tests/shared/src/test/scala/caseapp/Tests.scala b/tests/shared/src/test/scala/caseapp/Tests.scala
@@ -433,6 +433,22 @@ object Tests extends TestSuite {
       assert(res == expectedRes)
     }
 
+    "parser withHelp works with custom option formatter" - {
+      val res =
+        Parser[FewArgs]
+          .nameFormatter((n: Name) => n.name)
+          .withHelp
+          .detailedParse(
+            Seq("--value", "b", "--numFoo", "1")
+          )
+
+      val expectedRes =
+        Right(
+          (WithHelp(false, false, Right(FewArgs("b", 1))), RemainingArgs(List(), List()))
+        )
+      assert(res == expectedRes)
+    }
+
   }
 
 }