-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google AdSense support #47
Comments
I think it makes sense a reponsive adsense banner on top/bottom of articles. I've just implemented it in a fork. I'm going to PR for your apreciation. |
I think it's good to have more than two options. We could allow up to 5 places somewhere and the user choose where to place. For example: ADSENSE = {
'aside': 'some-id',
'article-bottom': 'another-id',
// ....
} |
Nice! Which other places do you think good to add banners? Do you agree to support only responsible banners? |
In my case I think I'll use only aside and article bottom. Two banners are good for me. But we could allow up to 5 places. |
Good idea, I'll try to implement it. |
Here where to place: Before closing |
Only responsible banners. Right? |
Not sure how they will work. As far I know AdSense works good with responsible banners, but we need to try. For example, aside must be a square banner, not sure if Google will know this. But we can try. |
The responsible banner, on load time, adapts for the browser. You can see it working here: http://gustavofurtado.com.br/seja-bom-no-essencial-programador.html Open it in your smartphone and open it in a desktop to see the difference. But when you resize your browser width after load the page, the banner keeps the size adjusted when it loaded. |
Good. Did you know that you can use Flex in pt_BR (aka HUEHUEHUEBR)? |
Yes, I know. I've just forgot to configurate. rsrs |
Well, it's very common and useful. But the question is: Where must the banners be placed?
It's not good to add 10 banners per page. One is annoying, so it must be something careful, or not done at all.
Just thinking about this today.
The text was updated successfully, but these errors were encountered: