Define common parameter for node anchoring in DatabaseChangeDetailsView

ref: JabRef#11220
alexandre-cremieux · Jun 23, 2024 · 8f91bf1 · 8f91bf1
1 parent a7deb7c
commit 8f91bf1
Show file tree

Hide file tree

Showing 9 changed files with 37 additions and 43 deletions.
diff --git a/src/main/java/org/jabref/gui/collab/DatabaseChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/DatabaseChangeDetailsView.java
@@ -1,5 +1,6 @@
 package org.jabref.gui.collab;
 
+import javafx.scene.Node;
 import javafx.scene.layout.AnchorPane;
 
 import org.jabref.gui.collab.entrychange.EntryChangeDetailsView;
@@ -12,5 +13,32 @@
 import org.jabref.gui.collab.stringdelete.BibTexStringDeleteDetailsView;
 import org.jabref.gui.collab.stringrename.BibTexStringRenameDetailsView;
 
-public sealed abstract class DatabaseChangeDetailsView extends AnchorPane permits EntryWithPreviewAndSourceDetailsView, GroupChangeDetailsView, MetadataChangeDetailsView, PreambleChangeDetailsView, BibTexStringAddDetailsView, BibTexStringChangeDetailsView, BibTexStringDeleteDetailsView, BibTexStringRenameDetailsView, EntryChangeDetailsView {
+public sealed abstract class DatabaseChangeDetailsView extends AnchorPane permits
+        EntryWithPreviewAndSourceDetailsView,
+        GroupChangeDetailsView,
+        MetadataChangeDetailsView,
+        PreambleChangeDetailsView,
+        BibTexStringAddDetailsView,
+        BibTexStringChangeDetailsView,
+        BibTexStringDeleteDetailsView,
+        BibTexStringRenameDetailsView,
+        EntryChangeDetailsView {
+
+    private static Double ANCHOR_PANE_OFFSET = 8D;
+
+    /**
+     * Set left, top, right, bottom anchors based on common offset parameter for the given child
+     * and attach it to children.
+     *
+     * @param child the child node of the implementation
+     * @see AnchorPane#getChildren()
+     * @see javafx.collections.ObservableList#setAll(Object[])
+     */
+    protected void setAllAnchorsAndAttachChild(Node child) {
+        setLeftAnchor(child, ANCHOR_PANE_OFFSET);
+        setTopAnchor(child, ANCHOR_PANE_OFFSET);
+        setRightAnchor(child, ANCHOR_PANE_OFFSET);
+        setBottomAnchor(child, ANCHOR_PANE_OFFSET);
+        this.getChildren().setAll(child);
+    }
 }
diff --git a/src/main/java/org/jabref/gui/collab/entrychange/EntryChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/entrychange/EntryChangeDetailsView.java
@@ -72,12 +72,7 @@ public EntryChangeDetailsView(BibEntry oldEntry,
         SplitPane split = new SplitPane(containerOld, containerNew);
         split.setOrientation(Orientation.HORIZONTAL);
 
-        setLeftAnchor(split, 8d);
-        setTopAnchor(split, 8d);
-        setRightAnchor(split, 8d);
-        setBottomAnchor(split, 8d);
-
-        this.getChildren().add(split);
+        this.setAllAnchorsAndAttachChild(split);
     }
 
     // Method adapted from:

diff --git a/src/main/java/org/jabref/gui/collab/groupchange/GroupChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/groupchange/GroupChangeDetailsView.java
@@ -17,11 +17,6 @@ public GroupChangeDetailsView(GroupChange groupChange) {
         Label label = new Label(labelValue);
         label.setWrapText(true);
 
-        setLeftAnchor(label, 8d);
-        setTopAnchor(label, 8d);
-        setRightAnchor(label, 8d);
-        setBottomAnchor(label, 8d);
-
-        getChildren().setAll(label);
+        this.setAllAnchorsAndAttachChild(label);
     }
 }
diff --git a/src/main/java/org/jabref/gui/collab/metedatachange/MetadataChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/metedatachange/MetadataChangeDetailsView.java
@@ -25,12 +25,8 @@ public MetadataChangeDetailsView(MetadataChange metadataChange, GlobalCitationKe
         }
 
         ScrollPane scrollPane = new ScrollPane(container);
-        getChildren().setAll(scrollPane);
 
-        setLeftAnchor(scrollPane, 8d);
-        setTopAnchor(scrollPane, 8d);
-        setRightAnchor(scrollPane, 8d);
-        setBottomAnchor(scrollPane, 8d);
+        this.setAllAnchorsAndAttachChild(scrollPane);
     }
 
     private String getDifferenceString(MetaDataDiff.DifferenceType changeType) {

diff --git a/src/main/java/org/jabref/gui/collab/preamblechange/PreambleChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/preamblechange/PreambleChangeDetailsView.java
@@ -27,11 +27,7 @@ public PreambleChangeDetailsView(PreambleChange preambleChange) {
         } else {
             container.getChildren().add(new Label(Localization.lang("Value cleared externally")));
         }
-        setLeftAnchor(container, 8d);
-        setTopAnchor(container, 8d);
-        setRightAnchor(container, 8d);
-        setBottomAnchor(container, 8d);
 
-        getChildren().setAll(container);
+        this.setAllAnchorsAndAttachChild(container);
     }
 }
diff --git a/src/main/java/org/jabref/gui/collab/stringadd/BibTexStringAddDetailsView.java b/src/main/java/org/jabref/gui/collab/stringadd/BibTexStringAddDetailsView.java
@@ -17,11 +17,7 @@ public BibTexStringAddDetailsView(BibTexStringAdd stringAdd) {
                 new Label(Localization.lang("Label: %0", stringAdd.getAddedString().getName())),
                 new Label(Localization.lang("Content: %0", stringAdd.getAddedString().getContent()))
         );
-        setLeftAnchor(container, 8d);
-        setTopAnchor(container, 8d);
-        setRightAnchor(container, 8d);
-        setBottomAnchor(container, 8d);
 
-        getChildren().setAll(container);
+        this.setAllAnchorsAndAttachChild(container);
     }
 }
diff --git a/src/main/java/org/jabref/gui/collab/stringchange/BibTexStringChangeDetailsView.java b/src/main/java/org/jabref/gui/collab/stringchange/BibTexStringChangeDetailsView.java
@@ -19,11 +19,7 @@ public BibTexStringChangeDetailsView(BibTexStringChange stringChange) {
         );
 
         container.getChildren().add(new Label(Localization.lang("Current content: %0", stringChange.getOldString().getContent())));
-        setLeftAnchor(container, 8d);
-        setTopAnchor(container, 8d);
-        setRightAnchor(container, 8d);
-        setBottomAnchor(container, 8d);
 
-        getChildren().setAll(container);
+        this.setAllAnchorsAndAttachChild(container);
     }
 }
diff --git a/src/main/java/org/jabref/gui/collab/stringdelete/BibTexStringDeleteDetailsView.java b/src/main/java/org/jabref/gui/collab/stringdelete/BibTexStringDeleteDetailsView.java
@@ -17,11 +17,7 @@ public BibTexStringDeleteDetailsView(BibTexStringDelete stringDelete) {
                 new Label(Localization.lang("Label: %0", stringDelete.getDeletedString().getName())),
                 new Label(Localization.lang("Content: %0", stringDelete.getDeletedString().getContent()))
         );
-        setLeftAnchor(container, 8d);
-        setTopAnchor(container, 8d);
-        setRightAnchor(container, 8d);
-        setBottomAnchor(container, 8d);
 
-        getChildren().setAll(container);
+        this.setAllAnchorsAndAttachChild(container);
     }
 }
diff --git a/src/main/java/org/jabref/gui/collab/stringrename/BibTexStringRenameDetailsView.java b/src/main/java/org/jabref/gui/collab/stringrename/BibTexStringRenameDetailsView.java
@@ -8,11 +8,7 @@ public final class BibTexStringRenameDetailsView extends DatabaseChangeDetailsVi
 
     public BibTexStringRenameDetailsView(BibTexStringRename stringRename) {
         Label label = new Label(stringRename.getNewString().getName() + " : " + stringRename.getOldString().getContent());
-        setLeftAnchor(label, 8d);
-        setTopAnchor(label, 8d);
-        setRightAnchor(label, 8d);
-        setBottomAnchor(label, 8d);
 
-        getChildren().setAll(label);
+        this.setAllAnchorsAndAttachChild(label);
     }
 }