Migrate to the Log4j 2 SLF4J Binding #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves to an underlying Log4j2 implementation while maintaining compatibility with the SLF4J API. This means that skills that transitively utilize this API through the dependency won't be broken but will be able to take advantage of the improvements of the new logger impl.
Motivation and Context
Concerns that Log4j1.x is obsolete and lacking in performance compared to 2.x. #129
Testing
The SDK itself uses Log4j through SLF4J and was not broken by this change.
Types of changes
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.