Merge pull request #680 from alex3165/bugfix/image-add-style-change

Fixing images on style change
alex3165 · Jan 23, 2019 · 6f17bac · 6f17bac
2 parents 03a34c6 + d32f764
commit 6f17bac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/jest/util.tsx b/src/jest/util.tsx
@@ -13,6 +13,7 @@ export const getMapMock = (override?: { [key: string]: any }) => ({
   setLayerZoomRange: jest.fn(),
   getLayer: jest.fn(),
   addImage: jest.fn(),
+  hasImage: jest.fn(),
   getSource: jest.fn().mockReturnValue({ setData: jest.fn() }),
   project: jest.fn(),
   ...override

diff --git a/src/layer.ts b/src/layer.ts
@@ -204,9 +204,11 @@ export default class Layer extends React.Component<Props> {
 
     if (images) {
       const normalizedImages = !Array.isArray(images[0]) ? [images] : images;
-      (normalizedImages as ImageDefinitionWithOptions[]).forEach(image => {
-        map.addImage(image[0], image[1], image[2]);
-      });
+      (normalizedImages as ImageDefinitionWithOptions[])
+        .filter(image => !map.hasImage(image[0]))
+        .forEach(image => {
+          map.addImage(image[0], image[1], image[2]);
+        });
     }
 
     if (!sourceId && !map.getSource(id)) {