Remove loops witch never loops fixes rust-ndarray#642

alex179ohm · Jul 4, 2019 · fdf984b · fdf984b
1 parent b1dc684
commit fdf984b
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/dimension/dimension_trait.rs b/src/dimension/dimension_trait.rs
@@ -130,9 +130,8 @@ pub trait Dimension:
         if self.slice().iter().all(|&d| d != 0) {
             let mut it = strides.slice_mut().iter_mut().rev();
             // Set first element to 1
-            while let Some(rs) = it.next() {
+            if let Some(rs) = it.next() {
                 *rs = 1;
-                break;
             }
             let mut cum_prod = 1;
             for (rs, dim) in it.zip(self.slice().iter().rev()) {
@@ -156,9 +155,8 @@ pub trait Dimension:
         if self.slice().iter().all(|&d| d != 0) {
             let mut it = strides.slice_mut().iter_mut();
             // Set first element to 1
-            while let Some(rs) = it.next() {
+            if let Some(rs) = it.next() {
                 *rs = 1;
-                break;
             }
             let mut cum_prod = 1;
             for (rs, dim) in it.zip(self.slice()) {