Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Lock time ilias #365

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Lock time ilias #365

merged 5 commits into from
Sep 26, 2022

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Sep 22, 2022

  1. I changed the bg of the toggle section to match the designs. The light theme however doesn't look nice and needs adjustment.
  2. Even though I added a min date for the datepicker field, it seems that I can still select a past hour (date works fine)

@nop33 nop33 requested review from mvaivre and LeeAlephium and removed request for mvaivre September 22, 2022 15:50
@LeeAlephium
Copy link
Contributor

Code 👍

Just one thing: in a side-channel discussion with @mvaivre we agreed it makes more sense to show local time, not UTC time. UTC time is just used internally - if you could change that back it'd be great 👌

Even though I added a min date for the datepicker field, it seems that I can still select a past hour (date works fine)

Let's log an issue #366

@LeeAlephium
Copy link
Contributor

LeeAlephium commented Sep 22, 2022

You can merge after that small change

@nop33 nop33 merged commit 179f5d9 into lock-time Sep 26, 2022
@nop33 nop33 deleted the lock-time-ilias branch September 26, 2022 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants