-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Test Coverage for packages/web3/src/utils #468
base: master
Are you sure you want to change the base?
Improve Test Coverage for packages/web3/src/utils #468
Conversation
@polarker please review |
Thanks for the contribution. Please make sure all the updated test suite pass, right now all of them have failing tests. You can run them by
|
Alright ser |
@h0ngcha0 Will update my PR Soon |
|
@h0ngcha0 Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@h0ngcha0 |
Closes #457
Improve Test Coverage for packages/web3/src/utils
Overview
This pull request significantly enhances the test coverage for the
utils.ts
file and other utility functions in thepackages/web3/src/utils
directory. We've added new test cases, improved existing ones, and created new test files to ensure comprehensive coverage of our utility functions.Main Changes
utils.test.ts
bs58.test.ts
isBase58
function:base58ToBytes
function:bs58
object:djb2.test.ts
djb2
function:subscription.test.ts (New File)
Subscription
class:TestSubscription
to test abstractSubscription
classAdditional Notes
utils.ts
resolve type errors related to theSignatureInput
typesubscription.test.ts
provides thorough coverage for theSubscription
class