Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DappTransactionBuilder #450

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Introduce DappTransactionBuilder #450

merged 3 commits into from
Nov 21, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Nov 19, 2024

No description provided.

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments & questions

packages/web3/src/contract/dapp-tx-builder.ts Outdated Show resolved Hide resolved
packages/web3/src/contract/dapp-tx-builder.ts Show resolved Hide resolved
Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@polarker polarker merged commit 69cb409 into master Nov 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants