Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error messages #433

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Improve the error messages #433

merged 3 commits into from
Oct 17, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Oct 17, 2024

Resolves #429

@Lbqds Lbqds requested review from polarker and h0ngcha0 October 17, 2024 01:30
polarker
polarker approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark.

packages/cli/scripts/deploy.ts Outdated Show resolved Hide resolved
@polarker polarker merged commit 02a776e into master Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarker polarker polarker approved these changes

@h0ngcha0 h0ngcha0 Awaiting requested review from h0ngcha0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw traceble error
2 participants
@Lbqds @polarker