Fix minor bugs #389
Merged
Fix minor bugs #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lbqds
commented
Jul 4, 2024
| import { ArrayCodec, DecodedArray } from './array-codec' | ||
|
|
||
| export interface PublicKeyHash { | ||
| publicKeyHash: Uint8Array | ||
| } | ||
|
|
||
| class PublicKeyHashCodec implements Codec<PublicKeyHash> { | ||
| parser = Parser.start().buffer('publicKeyHash', { length: 32 }) | ||
| parser = fixedSizeBytes('publicKeyHash', 32) |
There was a problem hiding this comment.
We are encountering an issue with the binary-parser library, which causes the lockupScriptCodec.decode(hexToBinUnsafe('01ca40da2a3f')) function to return a run out of memory error:
- Because the prefix is
1, it attempts to decodeP2MPKH. - The decoded array size is huge. And even if
fromandtoare out of the index,Uint8Array.subarray(from, to)does not throw an exception but returns an emptyUint8Array. Moreover,binary-parserdoes not check the length during runtime, leading to the allocation of a very large array and resulting in theout of memoryerror.
I feel like binary-parser lacks flexibility. It does not provide a direct way to check the size of the data. Currently it can only be checked through the wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.