Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VmClient.operate #194

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add VmClient.operate #194

merged 1 commit into from
Dec 13, 2024

Conversation

olethanh
Copy link
Contributor

Variation on perform_operation that allow a raw response. Move from the aleph-client code introduced in aleph-im/aleph-client#304

@olethanh olethanh requested a review from 1yam December 13, 2024 09:03
Copy link

Explanation:

The diff contains extensive changes that potentially introduce bugs or require deep understanding of the project architecture. Here are the highlights:

  1. New Method operate: The addition of a new method operate introduces a significant change to the existing codebase. This method is complex and involves multiple asynchronous operations, authentication, and HTTP requests.

  2. Dependencies and Imports: The addition of aiohttp.client._RequestContextManager and other imports suggests that this method is designed to handle asynchronous HTTP requests with context management, which could have broader implications for how the SDK interacts with external services.

  3. Authentication and Request Handling: The method includes detailed steps for generating authentication headers and making authenticated requests. This level of detail and complexity could lead to potential bugs if not implemented correctly.

  4. Potential Impact: The method is asynchronous and uses context managers, which could affect how other parts of the codebase interact with network operations. This could potentially impact the stability and performance of the SDK.

Given these factors, the PR is categorized as 'BLACK' due to the extensive changes and the potential for introducing bugs or requiring deep understanding of the project architecture. This level of complexity typically requires a high level of expertise and careful review.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Dec 13, 2024
@olethanh olethanh force-pushed the ol-vmclient-operate branch from a8bebef to 3baf228 Compare December 13, 2024 09:16
Variation on perform_operation that allow a raw response.
Move from the aleph-client code introduced in aleph-im/aleph-client#304
Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olethanh olethanh merged commit 1e2eebe into main Dec 13, 2024
12 checks passed
@philogicae philogicae deleted the ol-vmclient-operate branch December 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants