Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:Oauth_improve #1

Merged
merged 1 commit into from
Nov 24, 2021
Merged

docs:Oauth_improve #1

merged 1 commit into from
Nov 24, 2021

Conversation

alejandroparra
Copy link
Owner

SUMMARY

Hi there!
I was trying to set up the Custom OAuth2 Configuration but found out that one very important and necessary import is missing from the documentation in order to make the sample code work without any problem.

the import missing is with the library OAuth, after several hours of searching and reading found that importing only that library doesn't work, what it works is to import the full OAuth library from flask_appbuilder.security.manager.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ x] Has associated issue: Documentation update for OAuth configuration apache/superset#17544
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Hi there!
I was trying to set up the Custom OAuth2 Configuration but found out that one very important and necessary import is missing from the documentation in order to make the sample code work without any problem.

the import missing is with the library OAuth, after several hours of searching and reading found that importing only that library doesn't work, what it works is to import the full OAuth library from flask_appbuilder.security.manager.
@alejandroparra alejandroparra merged commit ec9a8f2 into master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant