-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamoDB: Item exists with specific values assertion #26
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2dad384
Cleaned up matching state machine output assertion
joelhamiltondev 0758f9d
Added assertion that dynamodb table contains item and that item conta…
joelhamiltondev be8eb9f
Cleaned up error and success messages.
joelhamiltondev 7b9ce41
Cleaning up code before submitting PR.
joelhamiltondev c20f339
Fixing merge conflicts.
joelhamiltondev 918b744
Made changes according to review.
joelhamiltondev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { testResult, TestResultOutput } from "utils/testResult"; | ||
import { AWSClient } from "helpers/general"; | ||
|
||
export default { | ||
async toContainItemWithValues( | ||
tableName: string, | ||
values: { [key: string]: unknown } | ||
): Promise<TestResultOutput> { | ||
const docClient = new AWSClient.DynamoDB.DocumentClient({ | ||
region: "us-east-1", | ||
}); | ||
let keys; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can be simplified to
|
||
if (values["SK"] !== undefined) { | ||
keys = { pk: values["PK"], sk: values["SK"] }; | ||
} else { | ||
keys = { pk: values["PK"] }; | ||
} | ||
const queryParams = { | ||
Key: keys, | ||
TableName: tableName, | ||
}; | ||
try { | ||
const result = await docClient.get(queryParams).promise(); | ||
Object.entries(values).forEach(([key, val]) => { | ||
if (result.Item?.[key] !== val) { | ||
return testResult( | ||
`Item was expected to have ${key} value of ${val}, but instead had ${key} value of ${result.Item?.[key]}`, | ||
false | ||
); | ||
} | ||
}); | ||
|
||
return testResult("Item exists with expected values", true); | ||
} catch (e: any) { | ||
console.log(e); | ||
|
||
return testResult("Item with specified keys does not exist.", false); | ||
} | ||
}, | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import the region from src/helpers/general instead of hard coding it