-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to add an auto-detected project as a favorite #229
Conversation
Hi @ckaczor , First of all, thanks for you PR and sorry for taking so long to answer. I was a bit busy in the last couple of weeks, with my vacation and the preparations for speaking at Embarcadero Conference. About your PR, I think that instead of a new command, you should reuse the Of course the Could you update the PR for that? Thank you |
Thanks for the feedback - I updated the commit with the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both calls to showStatusBar
(lines 304 and 325) should not occur if node
is not undefined. Otherwise, it will incorrectly update the status bar to show the "saved project", which in this case, is not the active
Hi @ckaczor , I'm finally returning to the PRs, and made two comments on that. Could you take a look? My intention is to start releasing updates in the weekend. Thank you |
Changes should be all set - thanks for the feedback =) |
I have a bunch of auto-detected projects and I wanted a quick way to add some as a favorite. This adds a context menu item that will quickly save a project as a favorite.