support Portable Mode #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support Portable Mode
|
Because I only have windows computers, so only tested the (win10 v1803) system. |
Closed
|
Hi @hcwhan , I just returned to look at this, and noted that it the Could you update that as well? |
alefragnani
requested changes
Nov 25, 2018
src/extension.ts
Outdated
| projectFile = path.join(appdata, channelPath, "User", PROJECTS_FILE); | ||
| } else { | ||
| appdata = process.env.APPDATA || (process.platform === "darwin" ? process.env.HOME + "/Library/Application Support" : "/var/local"); | ||
| channelPath: string = getChannelPath(); |
There was a problem hiding this comment.
TypeScript is complaining here...
[ts] 'string' only refers to a type, but is being used as a value here
alefragnani
approved these changes
Nov 28, 2018
|
Hi @hcwhan , It's still missing the changes on Once you push the changes, I could release an update including your PR. Thank you. |
This was referenced Dec 18, 2018
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support Portable Mode