Fixed extension not working if the VSCode folder was called "Code - OSS" #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Kurolox , Thanks for you PR. I will merge and update the extension later today. |
alefragnani
requested changes
Apr 23, 2018
src/extension.ts
Outdated
| @@ -594,6 +594,8 @@ export function activate(context: vscode.ExtensionContext) { | |||
| function getChannelPath(): string { | |||
| if (vscode.env.appName.indexOf("Insiders") > 0) { | |||
| return "Code - Insiders"; | |||
| } else if (vscode.env.appName.indexOf("OSS") > 0) { | |||
There was a problem hiding this comment.
I would make a small change. Instead of another if statement, it would be better to use:
function getChannelPath(): string {
return vscode.env.appName.replace("Visual Studio ", "");
}There was a problem hiding this comment.
Don't worry if you can't update the PR right now. I can do it myself before merging. I was just playing with code-review 😀
There was a problem hiding this comment.
Sure thing, I'll update it right now. I've never touched TypeScript, so I didn't want to take any chances and went with something simple that I knew it would work. This is better, though.
There was a problem hiding this comment.
That's great. Btw, my first TypeScript experience was also with VS Code extensions 😄
alefragnani
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically added an extra if statement when checking the value of vscode.env.appName, so if it has "OSS" on it, the path will be changed to
Code - OSSinstead ofCode, which was conflicting before making the extension unable to work.