-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save bookmarks as global #287
Comments
Hi @apj68 , I don't remember seeing similar request before, but I understand the idea. I wonder how you identify the reason/objective for specific bookmarks, when you open a file from different contexts. I mean, let's say you toggle a bookmark at line 10 in file But of course, I see people going YES and NO to see that bookmark. To me, in most cases, I would say No, but it's just an opinion. I have used Delphi for a long time, and it stores the bookmarks on its project file (similar to In the end, I would say it's doable, but when/how, it will depend on feedback/upvotes from other users. Thanks for your suggestion |
Just a complement to your comment/idea in #256, I wouldn't make bookmarks for files/folders. It would stay as |
Thanks for your response! Regarding duplicate bookmarks, ideally this would be configurable similar to multi-root so that folks that are accustomed to the per-session or per-file bookmarks can continue to use it as they do. For handling duplicate bookmarks you could do it similar to how vscode handles duplicate filenames in tabs: add the filename automatically to the bookmark so that it appears with the filename in any bookmark lists. For me, I use labels almost exclusively so it's not as much an issue but I see your point. |
I wasn’t saying duplicate bookmakrs, but just a thought on scenarios where you add a bookmark in file If you define Global bookmarks, no matter how/when/where you open I see at least one possible limitation (limited/no support for Remotes, like Containers, SSH, WSL, Visual Studio Online). The extension still doesn’t support remotes, but based on what I’ve learned, it could be an issue. |
AH, I see what you mean. In your example, you could have a bookmark for a project such as |
Exactly 👍 Yes, none of the VS Code windows knows about each other (just the You could try to use |
👍 Thanks for listening, @alefragnani ! 😄 |
Totally agree with @alefragnani and vote for global option similarly to settings.json! I don't ever have workspaces saved and each time pull up an on-demand machine. We have a mono-repo, this means my bookmarks may be very irrelevant for other folks, so it wouldn't make sense to use the option to check-in the bookmarks file into the repo. I would very much prefer to have a local bookmarks file and even better just specify some custom location for it in the local settings.json. |
This is a required feature. Please implement. |
Hi @tarekahf , As I said in But, if you need move bookmarks with the repo to another computer, you should use The Global bookmarks are not planned to support move to other computer. Mostly because Settings Sync doesn't supports, yet, syncing extensions data. And also, it wouldn't work on a cross platform scenario (path differs from Windows to Linux/MacOS). |
It would be cool to be able to toggle the bookmark 'type' to be either global or local. that way you can have all different settings. There could be another command "Toggle global bookmark" and then you can decide per bookmark if it is just for this project, or if it is globally relevant 🤔 |
This is an enhancement request to add an option to save all bookmarks in a single, global location (such as adjacent to
settings.json
). I realize the design currently is to intentionally limit bookmarks to per-file or per-session, however, I suggest that a third option that makes sense would be to allow the users to save all bookmarks from all files and sessions in a single, global bookmark file. I describe my personal rationale for this a bit in the comments of issue 256 but I think many people would find this a valuable option.Thanks for the great extension! I'm still just trying to adapt my work processes to live without global bookmarks 😄.
The text was updated successfully, but these errors were encountered: