Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks not saved #256

Closed
zvit opened this issue Nov 27, 2019 · 9 comments
Closed

Bookmarks not saved #256

zvit opened this issue Nov 27, 2019 · 9 comments

Comments

@zvit
Copy link

zvit commented Nov 27, 2019

I place a bookmark. When I reopen the file, the bookmark is gone.

@alefragnani
Copy link
Owner

Hi @zvit ,

Could you please provide more details?

  • Which OS/Version are you using
  • How is your workspace? Single or Multi-root folders?
  • Are you using any formatter extension?
  • Are you using Remote Development scenarios?

Thank you

@zvit
Copy link
Author

zvit commented Nov 27, 2019

Hey @alefragnani,

Below is the information you asked for.

Which OS/Version are you using
Win10 Pro v1909 Build 18363.476

How is your workspace? Single or Multi-root folders?
Single

Are you using any formatter extension?
No

Are you using Remote Development scenarios?
No

@alefragnani
Copy link
Owner

In this case:

  • Are you seeing any message/warning when you open the folder, or activate a bookmark?
  • Are you able to toggle a new bookmark when you reopen the folder?
  • Is the folder local. In your machine, or is a network folder?

Just to be clear, the bookmarks are stored “per session”, which means if you open folder C:\FolderOne\SubFolderA and toggle a bookmark in file x.txt, it will be available if you reopen folder C:\FolderOne\SubfolderA In VS Code. But if you open C:\FolderOne and navigates to file SubFolderA\x.txt it wont’t be any bookmark.

Hope this helps

@zvit
Copy link
Author

zvit commented Nov 27, 2019

Are you seeing any message/warning when you open the folder, or activate a bookmark?
No.

Are you able to toggle a new bookmark when you reopen the folder?
Yes.

Is the folder local. In your machine, or is a network folder?
Local

Not sure what you mean about the navigation. I don't use VS to navigate folders. In Windows Explorer I right click an ahk file and choose "edit with VS"

@alefragnani
Copy link
Owner

Not sure what you mean about the navigation. I don't use VS to navigate folders. In Windows Explorer I right click an ahk file and choose "edit with VS"

In this case (editing single file), the bookmark won’t be there too, because there is no “VS Code session” to store the information. Also, if you already have a VS Code window open (no matter in which folder) and you open a single file in Explorer, it will be opened in the latest focused VS Code window, which will be “another session”, and then, will have a different bookmarks storage

The Bookmarks are available only if you open Folders in VS Code

Hope this helps

@zvit
Copy link
Author

zvit commented Nov 27, 2019

Ok, thank you.
I will look for a plugin that embeds bookmarks into the file itself, much like how Photoshop embeds photos into the .psd file.

@alefragnani
Copy link
Owner

Sure, no problem 👍

I remember seeing some extensions that creates bookmarks “on the fly” based on regex/tokens, like TODO.

Hope this helps

@apj68
Copy link

apj68 commented Apr 7, 2020

@alefragnani - I'm trying to slowly convert to VS Code from Emacs. One feature of emacs that I use constantly is bookmarks. A key element to the way bookmarks work in emacs is that they are global. It's possible to bookmarks files, folders, as well as locations in files. This allows for the bookmarks to be a super-index of anything that you may be working on. If I understand your plugin functionality correctly each session has its own set of bookmarks and you can't create a bookmark to folders, only files. Do I understand correctly? Much like the OP, I use VS Code to pop open various folders and files, which are permanent files but not associated with a project or a persistent session. Would you consider adapting the design to persist bookmarks in some kind of global fashion?

@alefragnani
Copy link
Owner

Hi @apj68 , commented on #287 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants