Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globals not loaded automatically. #88

Closed
tregusti opened this issue Aug 27, 2018 · 3 comments
Closed

Globals not loaded automatically. #88

tregusti opened this issue Aug 27, 2018 · 3 comments
Assignees

Comments

@tregusti
Copy link

The globals config added in #29 is not used automatically. I get lots of warnings about browser, by and such.

I had to get and expose it myself:

const globals = require('eslint-plugin-protractor').configs.recommended.globals;

module.exports = {
    plugins: [
        'protractor'
    ],
    globals: { ...globals }
};

Maybe expose it as an environment as per the docs: https://eslint.org/docs/developer-guide/working-with-plugins#environments-in-plugins?

I'm using

  • eslint 4.19.1
  • eslint-plugin-protractor 1.40.2
@alecxe
Copy link
Owner

alecxe commented Aug 28, 2018

@tregusti thanks for the request and for using the plugin!

It's been a while I've personally used ESLint but I think I got what you meant. Please see if this solves your problem: e1db5e8. Thanks!

@alecxe
Copy link
Owner

alecxe commented Aug 28, 2018

It's now a part of 1.41.0 btw.

@tregusti
Copy link
Author

tregusti commented Sep 3, 2018

It works just fine. Thank you!

@tregusti tregusti closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants