feat(rules): improve CSS locator error context node selection

alecxe · Jun 21, 2017 · bc62086 · bc62086
1 parent 57092ca
commit bc62086
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/lib/rules/no-angular-attributes.js b/lib/rules/no-angular-attributes.js
@@ -24,7 +24,7 @@ module.exports = {
             extractedAttributes.forEach(function (extractedAttribute) {
               if (ANGULAR_ATTR_RE.test(extractedAttribute)) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected Angular attribute "' + extractedAttribute + '" inside a CSS selector'
                 })
               }

diff --git a/lib/rules/no-angular-classes.js b/lib/rules/no-angular-classes.js
@@ -34,7 +34,7 @@ module.exports = {
             for (var i = 0; i < prohibitedClasses.length; i++) {
               if (extractedClassNames.indexOf(prohibitedClasses[i]) >= 0) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected Angular class "' + prohibitedClasses[i] + '" inside a CSS selector'
                 })
               }

diff --git a/lib/rules/no-bootstrap-classes.js b/lib/rules/no-bootstrap-classes.js
@@ -23,7 +23,7 @@ module.exports = {
             for (var i = 0; i < bootstrapClasses.length; i++) {
               if (extractedClassNames.indexOf(bootstrapClasses[i]) >= 0) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected Bootstrap class "' + bootstrapClasses[i] + '" inside a CSS selector'
                 })
               }

diff --git a/lib/rules/no-compound-classes.js b/lib/rules/no-compound-classes.js
@@ -20,7 +20,7 @@ module.exports = {
 
             if (locatorValue.indexOf(' ') >= 0) {
               context.report({
-                node: node,
+                node: node.arguments[0],
                 message: 'No compound class names allowed.'
               })
             }

diff --git a/lib/rules/no-invalid-selectors.js b/lib/rules/no-invalid-selectors.js
@@ -22,7 +22,7 @@ module.exports = {
               parser.parse(cssSelector)
             } catch (err) {
               context.report({
-                node: node,
+                node: node.arguments[0],
                 message: 'Invalid CSS selector: "' + cssSelector + '"'
               })
             }

diff --git a/lib/rules/use-angular-locators.js b/lib/rules/use-angular-locators.js
@@ -26,7 +26,7 @@ module.exports = {
             Object.keys(attributeToLocatorMap).forEach(function (key) {
               if (node.arguments[0].value.indexOf(key) >= 0) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected "' + key + '" attribute used inside a CSS selector. Use ' + attributeToLocatorMap[key].join(' or ') + ' locator instead'
                 })
               }

diff --git a/lib/rules/use-simple-repeaters.js b/lib/rules/use-simple-repeaters.js
@@ -22,14 +22,14 @@ module.exports = {
             if (repeaterValue) {
               if (repeaterValue.indexOf('|') > 0) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected filter inside a by.repeater() locator.'
                 })
               }
 
               if (repeaterValue.indexOf('track by') > 0) {
                 context.report({
-                  node: node,
+                  node: node.arguments[0],
                   message: 'Unexpected "track by" inside a by.repeater() locator.'
                 })
               }